From 67d3bdfe6de8973627669831e7d03f9b6b396770 Mon Sep 17 00:00:00 2001 From: johnsoncodehk Date: Mon, 21 Mar 2022 00:17:22 +0800 Subject: [PATCH] fix: don't combine emmet completion with embedded languages completion close #1039 --- .../vue-language-service/src/languageFuatures/complete.ts | 4 ++-- packages/vue-language-service/src/languageService.ts | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/packages/vue-language-service/src/languageFuatures/complete.ts b/packages/vue-language-service/src/languageFuatures/complete.ts index dfb50f485..4efe80816 100644 --- a/packages/vue-language-service/src/languageFuatures/complete.ts +++ b/packages/vue-language-service/src/languageFuatures/complete.ts @@ -151,7 +151,7 @@ export function register(context: LanguageServiceRuntimeContext) { const embeddedCompletionList = await plugin.doComplete(sourceMap.mappedDocument, embeddedRange.start, completionContext); - if (!embeddedCompletionList) + if (!embeddedCompletionList || !embeddedCompletionList.items.length) continue; if (!plugin.context?.isAdditionalCompletion) { @@ -212,7 +212,7 @@ export function register(context: LanguageServiceRuntimeContext) { const completionList = await plugin.doComplete(document, position, completionContext); - if (!completionList) + if (!completionList || !completionList.items.length) continue; if (!plugin.context?.isAdditionalCompletion) { diff --git a/packages/vue-language-service/src/languageService.ts b/packages/vue-language-service/src/languageService.ts index e348d4d67..6df5e2f90 100644 --- a/packages/vue-language-service/src/languageService.ts +++ b/packages/vue-language-service/src/languageService.ts @@ -156,9 +156,6 @@ export function createLanguageService( useEmmetPlugin({ configurationHost, }), - { - isAdditionalCompletion: true, - }, ); const scriptTsPlugin = useTsPlugins( scriptTsLs,