Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Css references on properties when using scss functions #1481

Closed
lucas-labs opened this issue Jun 20, 2022 · 3 comments · Fixed by #1485
Closed

Css references on properties when using scss functions #1481

lucas-labs opened this issue Jun 20, 2022 · 3 comments · Fixed by #1485
Labels
bug Something isn't working

Comments

@lucas-labs
Copy link
Contributor

lucas-labs commented Jun 20, 2022 •
edited

I'm getting this kind of references report:
image

Whenever I use a function, the "references" label is shown on the css property I'm applying the function to.
Is this behaviour ok?
@johnsoncodehk
Copy link
Member

This is css class name parsing bug at https://github.com/johnsoncodehk/volar/blob/master/packages/vue-typescript/src/utils/parseCssClassNames.ts. I'm working on other issues, if someone want to try a fix please feel free to send a PR.

@johnsoncodehk johnsoncodehk added the bug Something isn't working label Jun 20, 2022
@lucas-labs
Copy link
Contributor Author

lucas-labs commented Jun 20, 2022 •
edited

Thanks for the tip @johnsoncodehk !
I'll give it a try and send a PR

@lucas-labs lucas-labs mentioned this issue Jun 20, 2022
Merged
@lucas-labs
Copy link
Contributor Author

lucas-labs commented Jun 20, 2022 •
edited

@johnsoncodehk I just sent a PR (#1485) regarding this issue. Feel free to check it out whenever you want!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: css classes parsing lucas-labs/volar
2 participants
@lucas-labs @johnsoncodehk