fix(vue-tsc): fix typescript 5 support #2555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typescript 5 will attempt to use the host `resolveModuleNameLiterals` if present, which prevents vue-tsc looking up Vue files. Set this as undefined so it defaults back to existing logic.
|
This may give some insight on using the |
Closed
|
Thank you for investigating it! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript 5 will attempt to use the host
resolveModuleNameLiteralsif present, which prevents vue-tsc looking up Vue files.Set this as undefined so it defaults back to existing logic.
I'm unsure on the api of
resolveModuleNameLiteralsso didn't try to implement a solution for this currently; thought it best to fallback to existing behavior and then discover if we get any benefits from using this API.