Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: better default inlay hint settings #3147

Merged
merged 6 commits into from Jun 14, 2023

Conversation

wenfangdu
Copy link
Contributor

@wenfangdu wenfangdu commented May 9, 2023

  • "vue.inlayHints.missingProps": true is very useful.
  • "vue.inlayHints.optionsWrapper": true creates distraction, therefore changed to false.

Closes #2468 (comment).

@rchl
Copy link
Collaborator

rchl commented Jun 14, 2023

Why are you updating html data here? Those changes don't seem to be relevant to the issue. And also don't carry any meaningful changes.

@wenfangdu
Copy link
Contributor Author

@rchl I'm wondering that too, it's triggered by CI, but using my info as the committer info:
image
image
It's rather confusing and scary, @johnsoncodehk can you please set the CI action to use the bot info as the committer info instead of the PR author info?

@wenfangdu
Copy link
Contributor Author

@rchl And now it's committing on behalf of @johnsoncodehk 🤷‍♂️
image
image
Looks like it's using the last committer info to make the CI action commit.

@johnsoncodehk
Copy link
Member

johnsoncodehk commented Jun 14, 2023

We used to enabled vue.inlayHints.optionsWrapper by default because a lot of people didn't know why they had unexpected component types. I'll see if it can be enabled by default only for debug.

I decided not to enable vue.inlayHints.missingProps by default, since users can enable it themselves.

It's rather confusing and scary, @johnsoncodehk can you please set the CI action to use the bot info as the committer info instead of the PR author info?

e29e064 should fixed the problem.

@johnsoncodehk johnsoncodehk merged commit 8cb14b0 into vuejs:master Jun 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] prop being passed but volar throws that it wasn't
3 participants