Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vue-tsc and incremental cache #3218

Merged
merged 5 commits into from
Jun 7, 2023

Conversation

lucasavila00
Copy link
Contributor

@lucasavila00 lucasavila00 commented May 23, 2023

I'm using https://github.com/volarjs/volar.js for another project, and I used vue-tsc as an example of using Volar.

On my Volar project, I found this bug.

This was how I fixed it there. I don't know if this is a good approach.

Closes #2756

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@vikingair
Copy link
Contributor

I'm getting really annoyed about this issue.

@johnsoncodehk Can you merge the PR?

@johnsoncodehk
Copy link
Member

Thank you for your investigation! Hopefully one day we can remove these patches.

@johnsoncodehk johnsoncodehk merged commit 0435d1a into vuejs:master Jun 7, 2023
haoqunjiang added a commit to haoqunjiang/create-vue that referenced this pull request Nov 9, 2024
It was introduced to work around a bug in `vue-tsc` that has been fixed
in vuejs/language-tools#3218
cexbrayat pushed a commit to vuejs/create-vue that referenced this pull request Nov 9, 2024
It was introduced to work around a bug in `vue-tsc` that has been fixed
in vuejs/language-tools#3218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vue-tsc ignores type errors in .vue files if the incremental setting is true
3 participants