- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: component type missing for TS 5.1.3 #3274
fix: component type missing for TS 5.1.3 #3274
Conversation
Not the right way to fix...? |
I'm fairly sure that if you declare those interfaces up-front then you will overwrite the original ones. For extending to work you'd need to first reference/import original types from those packages but you can't really do that since you don't know if those exist or not in the project. |
Hi @rchl! I have pushed a new commit. Could you please check it out if it works? |
I don't know if it's the right approach. As I said, I don't think it's OK to import packages that might not exist but maybe TS is fine with it... |
FYI the hack comes from Here |
Yes, the original logic is to ignore errors through |
Oh, I see now that the original code also imported those so I guess this is not any worse. |
close #3268, close #3265, close #3252
Ref: microsoft/TypeScript#54630