Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inline variables are wrongly transformed as ctxVars #3280

Merged
merged 8 commits into from Jun 14, 2023
Merged

fix: inline variables are wrongly transformed as ctxVars #3280

merged 8 commits into from Jun 14, 2023

Conversation

so1ve
Copy link
Member

@so1ve so1ve commented Jun 14, 2023

closes #3258

@so1ve
Copy link
Member Author

so1ve commented Jun 14, 2023

Oops. Why?

@johnsoncodehk
Copy link
Member

If localVars[id.text] is 0 or undefined, it means that the current code scope cannot access the local variable, so this is a problem that walkIdentifiers does not collect variables correctly.

@johnsoncodehk johnsoncodehk merged commit 22b07e7 into vuejs:master Jun 14, 2023
3 checks passed
@so1ve
Copy link
Member Author

so1ve commented Jun 14, 2023

Thanks for your explanation! Now I know how auto unwrapping works :)

@so1ve so1ve deleted the fix/inline-vars-interpolation branch June 14, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchl rchl rchl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't define variables in inline event handler: "Property does not exist on type"
3 participants
@so1ve @johnsoncodehk @rchl