fix: support type narrowing for components

[so1ve]

closes #3138

[so1ve]

I have to discard the changes in workflow file :(

[rchl]

I think you just need to run pnpm i to update the lock file to fix the CI.

[so1ve]

I think you just need to run pnpm i to update the lock file to fix the CI.

Yes, you are 100% right :)

However Johnson didn't update the lockfile in master branch, so we may push to master directly.

And I changed the workflow file by accident, I need to revert that later :(

[rchl]

I see that your workflow changes change line endings from Windows to Unix which seems like a good change overall but probably should be done separately.
(test.yml workflow is also using Windows line-endings)

[rchl]

BTW. I don't have access to be able to push to master but if you do then I suppose it might be a good idea.
Or otherwise we could create a separate PR that does just that.

[rchl]

fixing ci in #3352

[so1ve]

BTW. I don't have access to be able to push to master but if you do then I suppose it might be a good idea. Or otherwise we could create a separate PR that does just that.

I have the access to, but I think pushing directly without Johnson's permission is not a good idea. If you are interested, could you please help me revert the changes made to workflow file? (I'm unable to code now, but I can do this tomorrow) Thanks a lot!

[rchl]

I don't have write access to the repo so I can't help directly but you should be able to just merge master into your branch and those changes should go away.

[johnsoncodehk]

@rchl I added write permissions to you, in case we get hit by a bus.

[rchl]

I hope not :)
I won't have much time to help but thanks for that.