Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use faster method after config change #3393

Merged
merged 3 commits into from Jul 13, 2023
Merged

Use faster method after config change #3393

merged 3 commits into from Jul 13, 2023

Conversation

zardoy
Copy link
Contributor

@zardoy zardoy commented Jul 11, 2023 •
edited

Though I wonder wether we cant just update initialization options and use regular server restart like:

context.subscriptions.push(vscode.commands.registerCommand('volar.action.restartServer', async () => {
			clients[0]!.clientOptions.initializationOptions = await getInitializationOptions(ServerMode.PartialSemantic, context)
			clients[1]!.clientOptions.initializationOptions = await getInitializationOptions(ServerMode.Syntactic, context)
            // ...

@johnsoncodehk
Copy link
Member

Yes we can do this, thanks for suggesting!

@johnsoncodehk johnsoncodehk merged commit b35cd23 into vuejs:master Jul 13, 2023
3 checks passed
rchl added a commit to rchl/vue-language-tools that referenced this pull request Jul 13, 2023
@rchl
Merge remote-tracking branch 'origin/master' into fix/class-vue-2
bb3ea45 
* origin/master: (25 commits)
  chore: fix typo (vuejs#3399)
  chore: bump volar
  Deprecate language server `json.customBlockSchemaUrls` option (vuejs#3398)
  Use faster method after config change (vuejs#3393)
  test: change defineComponent to support JSX (vuejs#3384)
  fix(class references): non scoped classes resolution regression (vuejs#3381)
  perf: hoist regexp if possible (vuejs#3378)
  fix: camel case components is not recognized as used (vuejs#3377)
  fix: allow slots to have no arguments (vuejs#3376)
  fix: don't remove comments when comment is in the first line (vuejs#3365)
  chore: add test for vuejs#3353
  chore: check project kind
  feat(typescript): implement `getExternalFiles`
  chore: update lock
  chore: remove resolve tsconfig warn
  ci(language-service): update html data
  chore: remove serverStats command from package.json of VSCode extension (vuejs#3366)
  v1.8.4
  chore: changelog
  chore: unpin volar
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zardoy @johnsoncodehk