Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support custom configPath for createParsedCommandLineByJson #3456

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

qmhc
Copy link
Contributor

@qmhc qmhc commented Jul 29, 2023

I want to parse config content after overriding and I found two methods: createParsedCommandLine and createParsedCommandLineByJson.

createParsedCommandLine parse config via path and cannot specify the config content.

createParsedCommandLineByJson will always set config path to rootDir + '/jsconfig.json'.

So it would be great if createParsedCommandLineByJson can support custom config path.

qmhc and others added 3 commits July 29, 2023 18:36

Verified

This commit was signed with the committer’s verified signature. The key has expired.
AustinAbro321 Austin Abro

Verified

This commit was signed with the committer’s verified signature. The key has expired.
AustinAbro321 Austin Abro

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@johnsoncodehk
Copy link
Member

LGTM, thanks!

@johnsoncodehk johnsoncodehk merged commit 3f1a1c3 into vuejs:master Sep 6, 2023
rchl added a commit to rchl/vue-language-tools that referenced this pull request Sep 6, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* master:
  feat: support nested plugins (vuejs#3530)
  chore: add formatter for vue files (vuejs#3532)
  chore: add test for defineExpose
  Update README.md (vuejs#3486)
  doc: fix typo (vuejs#3461)
  chore: support custom configPath for createParsedCommandLineByJson (vuejs#3456)
  fix: correctly hyphen-case props (vuejs#3424)
  feat: Add Portuguese language (vuejs#3535)
  chore: format
  refactor: use volar services via a better interop way
  chore: bump volar services
  refactor: clear up tsconfigs
  chore: update sponsor
  chore: remove `resolution-mode=highest` for pnpm 8.7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants