fix: generic components should respect strictTemplates
#3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so1ve
changed the title
strictTemplates in generic componentsstrictTemplates
so1ve
changed the title
strictTemplatesstrictTemplates
This was referenced Aug 17, 2023
so1ve
changed the title
strictTemplatesstrictTemplates
|
Thanks for the PR, but this will break vue-tsc emit types (we currently lack tests for vue-tsc emit dts). I will look for a workaround. |
|
The original fix has been superseded by 8e6a8a9, the new changes will not affect emit types. |
|
Wow that would be nice! This commit fixed this issue on consumer side right? |
Right, we should avoid |
This was referenced Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3201, close #3318, close vuejs/core#8969