Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add tests for #3488, #3518 #3517

Merged
merged 16 commits into from Sep 25, 2023
Merged

test: add tests for #3488, #3518 #3517

merged 16 commits into from Sep 25, 2023

Conversation

so1ve
Copy link
Member

@so1ve so1ve commented Aug 30, 2023 •
edited

close #3488, close #3518

@rchl
Copy link
Collaborator

rchl commented Aug 31, 2023

Would it also make sense to have a test where only defineExpose is used and there is no local variable overriding it? Because that seemed to be the original issue.

@so1ve
Copy link
Member Author

so1ve commented Aug 31, 2023

@rchl Thanks! Updated.

@so1ve
Copy link
Member Author

so1ve commented Aug 31, 2023

🤔 I should use ts-expect-error

@so1ve so1ve changed the title fix: exclude exposed variables in __VLS_ctx fix: exclude exposed variables in __VLS_ctx and allow overriding local props and exposed variables Aug 31, 2023
@so1ve
Copy link
Member Author

so1ve commented Aug 31, 2023

Note: #3488 and #3518 are not identical, but since they are highly related so I'll fix them in this PR at the same time

@johnsoncodehk johnsoncodehk changed the title fix: exclude exposed variables in __VLS_ctx and allow overriding local props and exposed variables test: add test for ##3488 Sep 25, 2023
@johnsoncodehk johnsoncodehk changed the title test: add test for ##3488 test: add test for #3488 Sep 25, 2023
@johnsoncodehk johnsoncodehk changed the title test: add test for #3488 test: add test for #3488, #3518 Sep 25, 2023
@johnsoncodehk johnsoncodehk changed the title test: add test for #3488, #3518 test: add tests for #3488, #3518 Sep 25, 2023
@johnsoncodehk
Copy link
Member

Hi @so1ve, since #3488 has been fixed by #3591, we just keep the tests, thanks!

@johnsoncodehk johnsoncodehk merged commit c153572 into vuejs:master Sep 25, 2023
3 checks passed
@so1ve so1ve deleted the fix/issue-3488 branch September 25, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@so1ve @rchl @johnsoncodehk