feat: support nested plugins #3530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently I simply flatten all nested plugins. @sxzz How should we handle nested plugins with circular references? How does vite handle that case? |
|
Could you please make an example for me? |
|
Ugh. For example: const plugin = []
plugin.push(plugin)Calling |
|
@so1ve Vite and rollup won't handle this case. It's not a valid usage. |
|
Thanks! |
rchl
added a commit
to rchl/vue-language-tools
that referenced
this pull request
Sep 6, 2023
* master: feat: support nested plugins (vuejs#3530) chore: add formatter for vue files (vuejs#3532) chore: add test for defineExpose Update README.md (vuejs#3486) doc: fix typo (vuejs#3461) chore: support custom configPath for createParsedCommandLineByJson (vuejs#3456) fix: correctly hyphen-case props (vuejs#3424) feat: Add Portuguese language (vuejs#3535) chore: format refactor: use volar services via a better interop way chore: bump volar services refactor: clear up tsconfigs chore: update sponsor chore: remove `resolution-mode=highest` for pnpm 8.7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3437, supersedes #3528