Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import macros on-demand #3550

Merged
merged 9 commits into from Sep 12, 2023
Merged

fix: import macros on-demand #3550

merged 9 commits into from Sep 12, 2023

Conversation

so1ve
Copy link
Member

@so1ve so1ve commented Sep 9, 2023 •
edited

close #3433

@sxzz

@so1ve so1ve marked this pull request as draft September 9, 2023 09:03
@so1ve so1ve marked this pull request as ready for review September 9, 2023 09:19
@johnsoncodehk johnsoncodehk merged commit 799b2c9 into vuejs:master Sep 12, 2023
3 checks passed
@so1ve so1ve deleted the fix/issue-3433 branch September 13, 2023 09:44
@sxzz
Copy link
Member

sxzz commented Sep 21, 2023

I don't think we should import aliased macros. It should be handled by plugins. Currently it breaks downstream, like Vue Macros. @so1ve @johnsoncodehk
https://github.com/vue-macros/vue-macros/actions/runs/6250806658/job/16970478308?pr=507

@sxzz sxzz mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import declaration conflicts with local declaration
3 participants
@so1ve @sxzz @johnsoncodehk