fix(vue-tsc): prevent rebuild in incremental mode throwing error #3556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blake-newman
force-pushed
the
blake.newman/fix-incremental-mode
branch
2 times, most recently
from
f8e819a
to
38521b8
Compare
Fix rebuilding in incremental mode with tsbuildinfo file causing error.
blake-newman
force-pushed
the
blake.newman/fix-incremental-mode
branch
from
38521b8
to
f4c7a20
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix rebuilding in incremental mode with tsbuildinfo file causing error.
Secondary rebuilds cause the following error:
This is caused because the mapping of the exportedModules looks for
__vls__file id, but this has been removed in the other patches. This new patch filters this file which is virtual and removes it before mapping. This prevents the error occurring on rebuilds and composite mode.resolves: #3345
resolves: #2622