fix: use universal __VLS_ConstructorOverloads when emits type is not inlined
#3585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so1ve
changed the title
__VLS_ConstructorOverloads__VLS_ConstructorOverloads when emits type is not inlined
so1ve
changed the title
__VLS_ConstructorOverloads when emits type is not inlined__VLS_ConstructorOverloads when emits type is not inlined
|
This is 🔥, thanks! @so1ve @ShenQingchuan |
|
@johnsoncodehk Since we are doing a lot of gymnastics here, maybe we can keep the original implementation (generated version) for better performance? |
This was referenced Sep 24, 2023
so1ve
changed the title
__VLS_ConstructorOverloads when emits type is not inlined__VLS_ConstructorOverloads when emits type is not inlined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3542
Most of the types come from @ShenQingchuan, thanks a lot!