Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reafctor: remove __VLS_publicComponent #3591

Merged
merged 1 commit into from Sep 25, 2023
Merged

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Sep 25, 2023

close #3488

In the past, template virtual code used both __VLS_publicComponent and __VLS_internalComponent in order to reuse props types. Now it is changed to generate props option for __VLS_publicComponent and __VLS_internalComponent respectively, trading a little TS performance loss for accuracy.

@johnsoncodehk johnsoncodehk changed the title reafctor: unused __VLS_publicComponent reafctor: remove __VLS_publicComponent Sep 25, 2023
@johnsoncodehk johnsoncodehk merged commit e4b49f5 into master Sep 25, 2023
6 checks passed
@johnsoncodehk johnsoncodehk deleted the no-public-component branch September 25, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable defined in defineExpose should not be available in <template>
1 participant