Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make defineProps work when reading a property from defineProps() #3633

Merged
merged 9 commits into from Oct 8, 2023
Merged

fix: make defineProps work when reading a property from defineProps() #3633

merged 9 commits into from Oct 8, 2023

Conversation

so1ve
Copy link
Member

@so1ve so1ve commented Oct 7, 2023

close #3629

@johnsoncodehk
Copy link
Member

Thanks!

@johnsoncodehk johnsoncodehk merged commit 28013fc into vuejs:master Oct 8, 2023
3 checks passed
@sxzz
Copy link
Member

sxzz commented Oct 9, 2023

Another case broken

<script setup lang="ts">
const name = 'title'
defineProps([name])
</script>
image

@so1ve so1ve mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchl rchl rchl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking assigned props variable
4 participants
@so1ve @johnsoncodehk @sxzz @rchl