Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(class references): experimentalResolveStyleCssClasses regression #3689

Conversation

Ilanaya
Copy link
Contributor

@Ilanaya Ilanaya commented Oct 25, 2023

Resolves #3688

@@ -160,7 +160,7 @@ function createTsx(fileName: string, _sfc: Sfc, { vueCompilerOptions, compilerOp

for (const style of _sfc.styles) {
const option = vueCompilerOptions.experimentalResolveStyleCssClasses;
if ((option === 'always' || option === 'scoped') && style.scoped) {
if (option === 'always' || (option === 'scoped' && style.scoped)) {
Copy link
Contributor Author

@Ilanaya Ilanaya Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for reference, the code some lines above was initially correct

@johnsoncodehk johnsoncodehk merged commit 7844683 into vuejs:master Oct 26, 2023
3 checks passed
@johnsoncodehk
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

experimentalResolveStyleCssClasses regression (no class references in template)
2 participants