Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to Volar 2.0 alpha #3736

Merged
merged 21 commits into from Dec 6, 2023
Merged

feat: upgrade to Volar 2.0 alpha #3736

merged 21 commits into from Dec 6, 2023

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Nov 16, 2023 •
edited

Refs volarjs/volar.js#85

This PR only carries out API migration, and functional updates will be carried out in a separate PR.

@johnsoncodehk johnsoncodehk mentioned this pull request Nov 16, 2023
Open
41 tasks
@johnsoncodehk johnsoncodehk changed the title Prepare for Volar 1.12 Update to Volar 2.0 Nov 21, 2023
@johnsoncodehk johnsoncodehk changed the title Update to Volar 2.0 feat: upgrade to Volar 2.0 alpha Dec 5, 2023
@johnsoncodehk johnsoncodehk marked this pull request as ready for review December 5, 2023 19:52
@johnsoncodehk
Copy link
Member Author

I need to get a windows machine tomorrow. :/

@rchl
Copy link
Collaborator

rchl commented Dec 5, 2023

If you are on Mac then you can emulate windows with https://mac.getutm.app/
The Windows image is available for free from Microsoft.

@johnsoncodehk
Copy link
Member Author

If you are on Mac then you can emulate windows with mac.getutm.app The Windows image is available for free from Microsoft.

Thanks 👍

@johnsoncodehk johnsoncodehk force-pushed the volar-1.12 branch 2 times, most recently from 6a2e5b7 to db6d4d7 Compare December 5, 2023 21:01
@johnsoncodehk
Copy link
Member Author

The error is due to getCurrentDirectory() in createTester.ts returning "C:/xxx" on Windows, while typescript internally is using "c:/xxx" to filter path completion files.

@johnsoncodehk johnsoncodehk merged commit dab3e47 into master Dec 6, 2023
6 checks passed
@johnsoncodehk johnsoncodehk deleted the volar-1.12 branch December 6, 2023 13:54
so1ve pushed a commit to so1ve/language-tools that referenced this pull request Dec 7, 2023
@johnsoncodehk @so1ve
feat: upgrade to Volar 2.0 alpha (vuejs#3736)
ff55060
johnsoncodehk added a commit that referenced this pull request Dec 21, 2023
@johnsoncodehk
feat: upgrade to Volar 2.0 alpha (#3736)
c7ec93f
johnsoncodehk added a commit that referenced this pull request Dec 21, 2023
@johnsoncodehk
feat: upgrade to Volar 2.0 alpha (#3736)
e561e42
johnsoncodehk added a commit that referenced this pull request Dec 26, 2023
@johnsoncodehk
feat: upgrade to Volar 2.0 alpha (#3736)
e6dc885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnsoncodehk @rchl