Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component-type-helpers): correct type inference for FunctionalComponent #3766

Merged

Conversation

pinguet62
Copy link
Contributor

fixes #3764

@rchl
Copy link
Collaborator

rchl commented Nov 30, 2023

Can you add a test also?

@pinguet62
Copy link
Contributor Author

I pushed tests!
Please let me know if I need to add or change anything 😉

@pinguet62 pinguet62 force-pushed the ComponentSlots-FunctionalComponent branch from da5ae0b to 774d6b3 Compare December 5, 2023 15:40
@johnsoncodehk johnsoncodehk merged commit 8caca96 into vuejs:master Dec 5, 2023
3 checks passed
@johnsoncodehk
Copy link
Member

Thanks!

@pinguet62 pinguet62 deleted the ComponentSlots-FunctionalComponent branch December 5, 2023 18:29
@pinguet62 pinguet62 restored the ComponentSlots-FunctionalComponent branch December 5, 2023 18:42
so1ve pushed a commit to so1ve/language-tools that referenced this pull request Dec 6, 2023
…ponent (vuejs#3766)

Co-authored-by: Johnson Chu <johnsoncodehk@gmail.com>
so1ve pushed a commit to so1ve/language-tools that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ComponentSlots<> doesn't work with generic components (FunctionalComponent in general?)
3 participants