Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(language-core): generate global types in one virtual file #3803

Merged
merged 9 commits into from Dec 14, 2023

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Dec 14, 2023

This is a redo of #3534.

  • The language server designates the first virtual file as the global types holder when it generates the first virtual file, and generates the helper types on it.
  • vue-tsc creates additional dummy .vue files as global types holders to avoid global types emit to dts.
  • Each project's global types holder is known at the time of generating virtual files. Using the holder file name as the file registry key safely avoids conflicts caused by duplicate helper types when multiple projects in the repo share virtual files.
  • When the global types holder file is deleted, the global types holder is switched to another random file in the file registry (d4c0c5e)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant