fix: address transition type incompatibility with Vue 2.7.16 #3882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so1ve
reviewed
Feb 1, 2024
| @@ -1365,6 +1365,11 @@ export function generate( | |||
| continue; | |||
| } | |||
|
|
|||
| if (vueCompilerOptions.target < 3 && node.tag === 'transition' && prop.name === 'persisted') { | |||
There was a problem hiding this comment.
What will happen the tag is Transition?
There was a problem hiding this comment.
Good point. I thought it's normalized by the compiler.
|
Note that for some reason the error on this test does not reproduce when opening that file in VSCode and I totally don't get why. Seems like generated template doesn't include the But regardless of that, it's a real issue that shows up with vue-tsc and also with LSP-volar in Sublime Text. EDIT: I've analyzed and explained that behavior in the linked issue. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explained all in #3881
Fixes #3881