fix: exclude vue directive syntax injection in Angular bindings #3891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vue directive syntax captures take over required terminating characters for expressions inside Angular template bindings. These bindings are identifiable with `meta.ng-binding` (https://github.com/angular/vscode-ng-language-service/blob/5d73b53115db57ea868f11aa5caa4bc0d890bb12/syntaxes/template-tag.json#L43). angular/vscode-ng-language-service#1989 angular/vscode-ng-language-service#2005
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vue directive syntax captures take over required terminating characters for expressions inside Angular template bindings. These bindings are identifiable with
meta.ng-binding(https://github.com/angular/vscode-ng-language-service/blob/5d73b53115db57ea868f11aa5caa4bc0d890bb12/syntaxes/template-tag.json#L43).angular/vscode-ng-language-service#1989 angular/vscode-ng-language-service#2005
reviewer note: I'm the maintainer of the Angular VSCode extension. While I don't think it's necessary that we always maintain compatibility, it would be nice if our syntaxes played nicely together when there are simple solutions. This seemed like the cleanest solution but I'm open to other suggestions. I built this extension locally and it seems to resolve the issues.