fix(language-service): wait for tsserver to be ready when requesting auto insert .value
#3914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…auto insert `.value`
rchl
reviewed
Mar 1, 2024
| await sleep(250); | ||
| if (req !== currentReq) | ||
| return; | ||
|
|
||
| const enabled = await context.env.getConfiguration?.<boolean>('vue.autoInsert.dotValue') ?? true; | ||
| if (!enabled) | ||
| return; |
There was a problem hiding this comment.
Wouldn't it make sense to check this configuration before the newly added code?
There was a problem hiding this comment.
getConfiguration has a send request cost before Volar has cached the option, so it is best to place it after sleep.
There was a problem hiding this comment.
But now the unnecessary sleep will trigger for every document change, even if one is not using this option. Seems more wasteful than getting a configuration once that gets cached later.
There was a problem hiding this comment.
sleep is just setTimeout. Is it expensive if clearTimeout is not called in time?
8 tasks
so1ve
pushed a commit
to so1ve/language-tools
that referenced
this pull request
Mar 4, 2024
…auto insert `.value` (vuejs#3914)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
provideAutoInsertionEditis too eager (called 100ms after the document is changed). At this time, the tsserver may not have obtained the latest script changes, and the requested position parameter may be calculated at the wrong position.Even if an additional version is used to check whether the tsserver script has been synchronized, it does not mean that the type checker is currently available, because the tsserver must wait for the diagnosis to be completed to synchronize the internal state. If the TS API is called in advance in the request handle, it will also cause the tsserver status to be abnormal.
It is currently difficult to find a way to reliably handle tsserver state synchronization, so this PR simply waits 250ms to bypass the problem.