fix(component-meta): defineSlots allows empty params
#4093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `defineSlots` without a props argument it would throw an error. This fixes that, and makes sure the output is the same as with normal template slot usage.
Evertvdw
changed the title
defineslots empty function error (#4091)
|
@johnsoncodehk There are build errors introduced by the auto-fix workflow that you added. A heads up as you might want to know. |
|
LGTM, thanks! |
johnsoncodehk
changed the title
defineslots empty function error (#4091)defineslots empty function error
johnsoncodehk
changed the title
defineslots empty function errordefineSlots allows empty params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using defineSlots without a function argument it would throw an error as
paramTypecan be undefined in that case. By adding this check this can be prevented.I used a
getAnyTypenow in case of no types, but I'm not sure if that is the best approach. The equivelent using a template-slot will generate an empty object as type. I'm not sure why and how to replicate that in this code, feel free to improve.