Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Insert: Bracket Spacing doesn't work with multiple cursor #4140

Closed
mrleblanc101 opened this issue Mar 21, 2024 · 7 comments
Closed

Auto Insert: Bracket Spacing doesn't work with multiple cursor #4140

mrleblanc101 opened this issue Mar 21, 2024 · 7 comments
Labels
bug Something isn't working good reproduction ✨ This issue provides a good reproduction, we will be able to investigate it first upstream

Comments

@mrleblanc101
Copy link

It work with a single cursor:
2024-03-21 17 02 02

It does not work with multiple cursor:
2024-03-21 17 02 34

Only the first cursor will get the space around the brackets and all other cursor will be lost which is kind of annoying.

@so1ve so1ve added bug Something isn't working good reproduction ✨ This issue provides a good reproduction, we will be able to investigate it first labels Mar 22, 2024
@asylbek23
Copy link

This error has been around for a long time

@so1ve
Copy link
Member

so1ve commented Mar 22, 2024

@asylbek23 Dude, no one has reported this problem before. Sending "this error has been around for a long time" here won't help it get fixed.

@asylbek23
Copy link

@asylbek23 Dude, no one has reported this problem before. Sending "this error has been around for a long time" here won't help it get fixed.

Your answer too

@mrleblanc101
Copy link
Author

mrleblanc101 commented Mar 22, 2024

@so1ve I wonder if I could open this as a Feature Request for vscode.
Currently this need to be implemented per language, but curly space is pretty standard accros all templating language.
VS Code could even support spacing for {% %}, {# #} and all the other variation 🤔

@so1ve
Copy link
Member

so1ve commented Mar 23, 2024

But I'd like to know if the vscode are willing to implement this feature. They don't add spaces inside import {/*here*/} from "";.

Anyway, this is still a bug that we are not handling multiple cursors well. We'll fix it.

@mrleblanc101
Copy link
Author

mrleblanc101 commented Mar 23, 2024

True, I guess I'm used to prettier doing it on save, which is does for Vue double curly too, but it's nice to have it on type.

@johnsoncodehk
Copy link
Member

I think this problem cannot be solved directly on the Vue language tools side, it requires changing Volar's auto insertion logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good reproduction ✨ This issue provides a good reproduction, we will be able to investigate it first upstream
Projects
None yet
Development

No branches or pull requests

4 participants