Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(language-core): move declare defineProp out of function scope #4454

Merged
merged 4 commits into from
Jun 21, 2024
Merged

fix(language-core): move declare defineProp out of function scope #4454

merged 4 commits into from
Jun 21, 2024
+23 −13

Conversation

zhiyuanzmj
Copy link
Member

@zhiyuanzmj zhiyuanzmj commented Jun 9, 2024 •
edited
Loading

1. Add PropOptions type for defineProp

image

2. prevent declare function in function scope.

image

zhiyuanzmj added 2 commits June 9, 2024 16:40
@zhiyuanzmj
fix(language-core): move declare defineProp out of function scope

Verified

This commit was signed with the committer’s verified signature.
romainmenke Romain Menke
GPG key ID: 0AF9E80487445907
Verified
Learn about vigilant mode
Loading
Loading status checks…
18f5ae6
@zhiyuanzmj
chore: up

Verified

This commit was signed with the committer’s verified signature.
romainmenke Romain Menke
GPG key ID: 0AF9E80487445907
Verified
Learn about vigilant mode
Loading
Loading status checks…
e22650e
zhiyuanzmj and others added 2 commits June 18, 2024 09:15
@zhiyuanzmj
Update scriptSetup.ts

Verified

This commit was signed with the committer’s verified signature.
romainmenke Romain Menke
GPG key ID: 0AF9E80487445907
Verified
Learn about vigilant mode
Loading
Loading status checks…
a4ef65a
@johnsoncodehk
move generateDefineProp

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
20ad240
@johnsoncodehk
Copy link
Member

LGTM, thanks!

@johnsoncodehk johnsoncodehk merged commit 0781998 into vuejs:master Jun 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@so1ve so1ve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhiyuanzmj @johnsoncodehk @so1ve