Slow suggestions

[Zenthae]

Using Volar, auto completion become unusable because it can takes seconds to display the suggestion, when, most of the time you already have finished typing. I've seen #455 but i don't know if it's linked, i tested with every extension disabled other than volar 0.27.21

[johnsoncodehk]

Please try to provide repro case, see #507 (comment).

[Zenthae]

there is no need of repro case, i just tested with default volar-starter and it's behaving the same way, suggestion is slow to display/load (and no it's not the timeout config)

[johnsoncodehk]

Have you try disable other extensions? And please also make sure volar.lowPowerMode is disabled.

Please provide your VSCode info by Help: About command, and profiling record: #413

[Zenthae]

i tested with every extension disabled other than volar 0.27.21

VSCode Info :

Version: 1.60.1 (system setup)
Commit: 83bd43bc519d15e50c4272c6cf5c1479df196a4d
Date: 2021-09-10T17:07:10.714Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19043

volar.lowPowerMode is set to false

little example of what i'm trying to say, and btw, the part before displaying Loading... is also about 0.5 sec long

[johnsoncodehk]

Can you compare the auto-complete speed of plain ts and SFC's <script> block with the same code to rule out that this is not a ts issue?

[Zenthae]

here is the chrome profile

Profile.zip

[Zenthae]

Can you compare the auto-complete speed of plain ts and SFC's <script> block with the same code to rule out that this is not a ts issue?

if i understood you right, here it is, a lot faster even if it's still a bit slow for my liking (but i should stop asking for the moon xD)

[johnsoncodehk]

You need to compare it by same code with same auto-complete trigger offset, because inside setup(), auto-complete is much slower due to TS overhead.

👇 the tryGetThisTypeAt calculate only occur in defineComponent's setup() function.

[Zenthae]

like this ?

[Zenthae]

maybe it'll be easier like this, here is my current repo https://github.com/Zenthae/seer/tree/v2
i invited you so you should be able to clone it to test

[johnsoncodehk]

It seem typescript-language-features has additional completion cache logic, will try to implement, but it's not easy.

[moliyu]

i think this problem just only appear in windows

[CrystalWindSnake]

I think it can be compared with vetur. Now the prompt speed of volar seriously affects the user experience. And I think volar is now much slower than before

[johnsoncodehk]

I think it can be compared with vetur. Now the prompt speed of volar seriously affects the user experience. And I think volar is now much slower than before

Please try to downgrade volar and let me know which version occur the problem beginning.

[Zenthae]

slower than vanilla TS but still a lot better than before.

[arpadgabor]

@Zenthae what version did you switch to? I'm also having performance issues with Volar, albeit my i7-7500U is pretty old now so that might also slow it down.

[Zenthae]

for my latest gif i used the latest version available which is v0.27.24

[CrystalWindSnake]

I think it can be compared with vetur. Now the prompt speed of volar seriously affects the user experience. And I think volar is now much slower than before

Please try to downgrade volar and let me know which version occur the problem beginning.

I tried to use the old version v0.22.23 of volar, and use the import module statement in the setup script, which is significantly faster than the latest version of volar

The following is the information output of the 2 versions。
I only enter "im" and wait for the prompt "import from" statement

v0.22.23 of volar：

Received response 'textDocument/completion - (15)' in 1164ms.

v0.27.24 of volar：

Received response 'textDocument/completion - (9)' in 1796ms.

[johnsoncodehk]

@CrystalWindSnake could you run debug mode to check is the problem occur begin in this commit 15e744f ?

Please also provide:

• VSCode info by Help: About command
• TS version if you are using workspace TS module

[CrystalWindSnake]

I think it can be compared with vetur. Now the prompt speed of volar seriously affects the user experience. And I think volar is now much slower than before

Please try to downgrade volar and let me know which version occur the problem beginning.

I tried to use the old version v0.22.23 of volar, and use the import module statement in the setup script, which is significantly faster than the latest version of volar

The following is the information output of the 2 versions。
I only enter "im" and wait for the prompt "import from" statement

v0.22.23 of volar：

Received response 'textDocument/completion - (15)' in 1164ms.

v0.27.24 of volar：

Received response 'textDocument/completion - (9)' in 1796ms.

I found that the new version of volar will repeatedly send completion messages.
When I enter "im", he will receive "Received response 'textDocument/completion" messages twice

[CrystalWindSnake]

@CrystalWindSnake could you run debug mode to check is the problem occur begin in this commit 15e744f ?

Please also provide:

• VSCode info by Help: About command
• TS version if you are using workspace TS module

VSCode info by Help: About ：

版本: 1.60.2 (user setup)
提交: 7f6ab5485bbc008386c4386d08766667e155244e
日期: 2021-09-22T12:00:31.514Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19042

TS version(This is the prompt version of volar in the lower right corner of the interface):

TS 4.4.3

I found that the new version of volar will repeatedly send completion messages.
When I enter "im", he will receive "Received response 'textDocument/completion" messages twice，and the old version is only sent once.
Is this the cause of the problem?

[johnsoncodehk]

@CrystalWindSnake I think you received 2 responses because you get a incomplete completion result when you typed i. When you typed m, TS calculate the complete result.

0.27.5 has related changes, please let me know if it's effect to you.

[CrystalWindSnake]

@CrystalWindSnake I think you received 2 responses because you get a incomplete completion result when you typed i. When you typed m, TS calculate the complete result.

0.27.5 has related changes, please let me know if it's effect to you.

Thank you, hope volar will get better and better

[nlvedwin]

also in macos this problem occurs slow but vetur is faster

[johnsoncodehk]

@nlvedwin can you provide repro case?

[jahnli]

@johnsoncodehk 我在windows上，也遇到了同样的问题，应该如何解决

[johnsoncodehk]

@chivesssss, @zhoujingfu see #455.

@jahnli please provide repro case otherwise I can't check.

[arsize]

I think it can be compared with vetur. Now the prompt speed of volar seriously affects the user experience. And I think volar is now much slower than before

Please try to downgrade volar and let me know which version occur the problem beginning.

Maybe 0.29.0

[jahnli]

@johnsoncodehk I don't know how to reproduce. At present, Windows will be slow if it only installs a volar code prompt. After uninstallation, it will be restored to normal

[johnsoncodehk]

Please track #808.