Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some RFC already implemented in the latest Vue, should it be classified? #162

Closed
chenxeed opened this issue Apr 24, 2020 · 2 comments
Closed

Comments

@chenxeed
Copy link

Hi!

I'm currently reading the RFC in the ./active-rfcs folder, and I realized some RFC were already implemented in the production of the latest release, for ex:

https://github.com/vuejs/rfcs/blob/master/active-rfcs/0001-new-slot-syntax.md
https://github.com/vuejs/rfcs/blob/master/active-rfcs/0002-slot-syntax-shorthand.md
https://github.com/vuejs/rfcs/blob/master/active-rfcs/0003-dynamic-directive-arguments.md

Currently they have been implemented and released in Vue v2.6.x.

Since there's a RFC Lifecycle statuses, should we classify the current list in ./active-rfcs to simply define which one that has been landed, or rejected?

@smolinari
Copy link
Contributor

Yeah, unfortunately, in the two slot RFCs, the links back to the PRs are missing. It's the PR that shows the status. i.e. merged means it's been adopted.

#2
#3
vuejs/vue#9373

You'd probably be better off looking at the PRs, as they link to the "rendered" detailed descriptions, which you are reading. The merged and closed PRs have been adopted, i.e. they are or will be added to Vue.

(that is my understanding of how the RFC process works)

Scott

@posva
Copy link
Member

posva commented Apr 24, 2020

I fixed the dead links in the Prs mentioned on the issue. Feel free to leave a comment when a Rendered link is dead

@posva posva closed this as completed Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants