Skip to content

Commit

Permalink
feat(devtools): use api.now()
Browse files Browse the repository at this point in the history
  • Loading branch information
posva committed Mar 10, 2022
1 parent db92787 commit 06ac7bb
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions src/devtools.ts
Expand Up @@ -157,7 +157,7 @@ export function addDevtools(app: App, router: Router, matcher: RouterMatcher) {
title: 'Error during Navigation',
subtitle: to.fullPath,
logType: 'error',
time: Date.now(),
time: api.now(),
data: { error },
groupId: (to.meta as any).__navigationId,
},
Expand Down Expand Up @@ -185,7 +185,7 @@ export function addDevtools(app: App, router: Router, matcher: RouterMatcher) {
api.addTimelineEvent({
layerId: navigationsLayerId,
event: {
time: Date.now(),
time: api.now(),
title: 'Start of navigation',
subtitle: to.fullPath,
data,
Expand Down Expand Up @@ -226,7 +226,7 @@ export function addDevtools(app: App, router: Router, matcher: RouterMatcher) {
event: {
title: 'End of navigation',
subtitle: to.fullPath,
time: Date.now(),
time: api.now(),
data,
logType: failure ? 'warning' : 'default',
groupId: (to.meta as any).__navigationId,
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
Expand Up @@ -1220,9 +1220,9 @@
"@vue/shared" "3.2.31"

"@vue/devtools-api@^6.0.0":
version "6.0.12"
resolved "https://registry.yarnpkg.com/@vue/devtools-api/-/devtools-api-6.0.12.tgz#7b57cce215ae9f37a86984633b3aa3d595aa5b46"
integrity sha512-iO/4FIezHKXhiDBdKySCvJVh8/mZPxHpiQrTy+PXVqJZgpTPTdHy4q8GXulaY+UKEagdkBb0onxNQZ0LNiqVhw==
version "6.0.13"
resolved "https://registry.yarnpkg.com/@vue/devtools-api/-/devtools-api-6.0.13.tgz#33f8debe2d0239903b6fc8af10ace45ed3a4fab1"
integrity sha512-T34EjcArVqzANedEZe2kXQ+AZsld2z1ptJlkOGm87+blk+s6udnP4ze/NYqV8lz1o9AIivimN0xxteLlWiWQdg==

"@vue/reactivity-transform@3.2.29":
version "3.2.29"
Expand Down

4 comments on commit 06ac7bb

@DotCoyote
Copy link

@DotCoyote DotCoyote commented on 06ac7bb Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit causes a bug with the devtools version 6.0.12 in brave (api.now is not a function). Works with 6.0.13 again, maybe a hint would be nice

@sbscan
Copy link

@sbscan sbscan commented on 06ac7bb Mar 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DotCoyote I also have api.now bug in Chrome, but not always. Maybe some extension making trouble?

@posva
Copy link
Member Author

@posva posva commented on 06ac7bb Mar 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Akryum did I release a version too soon for this api change? I thought the change didn't require the devtools version to upgrade

@sbscan
Copy link

@sbscan sbscan commented on 06ac7bb Mar 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've put my tags inside , now works. Not sure but should be working before OR I'm confused. But anyway my router-links now working with 4.0.14

Please sign in to comment.