fix(types): Support undefined in NavigationGuardNext (#1059)

vuejs · Aug 3, 2021 · 6cce232 · 6cce232
1 parent d8fb7d0
commit 6cce232
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/types/index.ts b/src/types/index.ts
@@ -370,7 +370,7 @@ export interface NavigationGuardNext {
   (): void
   (error: Error): void
   (location: RouteLocationRaw): void
-  (valid: boolean): void
+  (valid: boolean | undefined): void
   (cb: NavigationGuardNextCallback): void
   /**
    * Allows to detect if `next` isn't called in a resolved guard. Used

diff --git a/test-dts/navigationGuards.test-d.ts b/test-dts/navigationGuards.test-d.ts
@@ -26,6 +26,10 @@ router.beforeEach((to, from) => {
   return false
 })
 
+router.beforeEach((to, from, next) => {
+  next(undefined)
+})
+
 // @ts-expect-error
 router.beforeEach((to, from, next) => {
   return Symbol('not supported')