Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix($route): Make $route have an enumerable type #912

Merged
merged 1 commit into from Apr 28, 2021
Merged

fix($route): Make $route have an enumerable type #912

merged 1 commit into from Apr 28, 2021

Conversation

pdsuwwz
Copy link
Contributor

@pdsuwwz pdsuwwz commented Apr 28, 2021

Fix #902

posva
posva approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This makes sense given how $router is defined. Note you should still not use ctx 😉

@posva posva merged commit d90520e into vuejs:master Apr 28, 2021
@pdsuwwz pdsuwwz deleted the fix/902/enumerable-route-context branch April 28, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why the $route is not in the ctx but can be found and parsed in the template
2 participants
@pdsuwwz @posva