fix(find): implement proper find for multi-root components #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmiller1990
approved these changes
Nov 30, 2021
| return result | ||
| } else if (vnode.shapeFlag & ShapeFlags.ARRAY_CHILDREN) { | ||
| const children = (vnode.children as unknown as VNodeArrayChildren).flat( | ||
| Infinity |
There was a problem hiding this comment.
Have not seen this flat/Infinity before, neat
| const children = (vnode.children as unknown as VNodeArrayChildren).flat( | ||
| Infinity | ||
| ) as VNode[] | ||
|
|
There was a problem hiding this comment.
Figuring this entire function out must be been complex, nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to implement proper support for multi-root components.
This will include:
find(this PR)findAllandfindAllComponents.htmland.emitsFor sake of simplicity this PR is focused solely on fixing
find