New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(emitted): do not track native events on multi-root components #1121

Merged

cexbrayat merged 1 commit into master from multiroot-emit

Dec 1, 2021

Collaborator

xanf commented Dec 1, 2021

This PR makes our native event tracking behavior in line with Vue3 - see https://stackblitz.com/edit/vue-apcqqg?file=src%2FApp.vue for demo

Vue3 warns and does not track native events if:

we render more than one element root node
we render 0 element root nodes


          fix(emitted): do not track native events on multi-root components

c671556

cexbrayat approved these changes

View reviewed changes

cexbrayat merged commit 96a0af9 into master

cexbrayat deleted the multiroot-emit branch

December 1, 2021 07:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment