fix(find): find and findAll should not find itself on DOM wrappers #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
xanf
force-pushed
the
fix-do-not-include-self
branch
from
54c335e
to
65ee480
Compare
xanf
commented
Mar 26, 2022
| @@ -93,18 +94,6 @@ describe('find', () => { | |||
| expect(wrapper.find('.foo').exists()).toBe(true) | |||
| }) | |||
|
|
|||
| it('returns the root element from dom wrapper if it matches', () => { | |||
There was a problem hiding this comment.
This test now makes no sense, it captured previous behavior
I've added alternate test at the bottom of this file
xanf
force-pushed
the
fix-do-not-include-self
branch
from
65ee480
to
6484d0b
Compare
lmiller1990
approved these changes
Mar 28, 2022
|
Let's ship it 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is alternate approach to fix #1233
Other approach: #1377
What I'm liking about this approach:
findAllimplementation toDOMWrapper/VueWrapperto distinguish behavior on Vue wrapper / DOM (semantics 🥇 )