Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Vue (3.2.x) #861

Closed
lmiller1990 opened this issue Aug 12, 2021 · 5 comments
Closed

Update to latest Vue (3.2.x) #861

lmiller1990 opened this issue Aug 12, 2021 · 5 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@lmiller1990
Copy link
Member

lmiller1990 commented Aug 12, 2021

I tried updating the deps to Vue 3.2.2, but get this error when running the tests.

 FAIL  tests/docs-examples/teleport.spec.ts
  ● Test suite failed to run

    src/stubs.ts:52:3 - error TS2590: Expression produces a union type that is too complex to represent.

     52   return defineComponent({
          ~~~~~~~~~~~~~~~~~~~~~~~~
     53     name: name || anonName,
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ...
     56     props: propsDeclaration || {}
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     57   })
        ~~~~

We should find out what's going on and fix it so we can update.

@lmiller1990 lmiller1990 added the dependencies Pull requests that update a dependency file label Aug 12, 2021
@TheDutchCoder
Copy link
Contributor

This might be related, but when upgrading Vue, the following errors are thrown when running jest: Cannot find module '@vue/compiler-dom' from 'node_modules/@vue/test-utils/dist/vue-test-utils.cjs.js'

The latest version of seems to remove the compiler-dom from the lock file and there was a release note about conflicting compiler/runtime: https://github.com/vuejs/vue-next/blob/master/CHANGELOG.md#compatibility-notes

@lmiller1990
Copy link
Member Author

Interesting. I think I bumped all the versions (including compiler-dom) but I'll give it another go.

@TheDutchCoder
Copy link
Contributor

Interesting. I think I bumped all the versions (including compiler-dom) but I'll give it another go.

As soon as 3.2.4 hit, the errors were gone, so I think it might've been a Vue issue. Thinks work for me now!

@xanf
Copy link
Collaborator

xanf commented Aug 26, 2021

I've opened #889 to address this

@lmiller1990
Copy link
Member Author

It's done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants