Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: string slot null ctx in renderFn #1462

Merged
merged 1 commit into from Apr 29, 2022
Merged

fix: string slot null ctx in renderFn #1462

merged 1 commit into from Apr 29, 2022

Conversation

braddialpad
Copy link
Contributor

Fix for #1166. Render function requires ctx as the first param. This was not being passed in so was always null and erroring out. Bit confused why this only seems to be happening for Mocha users. Seems like it would be null for everyone.

@netlify
Copy link

netlify bot commented Apr 28, 2022

Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit c39e6f2
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/626b05352865fb00098d55e5
😎 Deploy Preview https://deploy-preview-1462--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. We should add a mocha + webpack test runner combo too, to verify this doesn't regress (and that it actually works) but this seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants