Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: #1476 reactive prop object compare #1479

Merged
merged 4 commits into from May 20, 2022

Conversation

freakzlike
Copy link
Collaborator

@freakzlike freakzlike commented May 4, 2022

Regression test and fix for issue #1476

fix #1476

@netlify
Copy link

netlify bot commented May 4, 2022

Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit 8d08676
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/62826818c149da0009e034ce
😎 Deploy Preview https://deploy-preview-1479--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@freakzlike
Copy link
Collaborator Author

I tried some implementation but I was not able to find a good solution which allows both cases (#192 and #1476) to work. Now I have a working solution, but it feels rather uncomfortable.

Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

@lmiller1990 lmiller1990 merged commit bb1a378 into vuejs:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: DOM sometimes not being updated
2 participants