Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add return type to createStub #1544

Merged
merged 1 commit into from May 27, 2022

Conversation

cexbrayat
Copy link
Member

Fixes the error:

src/index.ts → dist/vue-test-utils.esm-bundler.mjs...
[!] (plugin commonjs--resolver) Error: /home/runner/work/test-utils/test-utils/src/stubs.ts(77,14): semantic error TS2742: The inferred type of 'createStub' cannot be named without a reference to '@vue/compiler-dom/node_modules/@vue/shared'. This is likely not portable. A type annotation is necessary.

that we see when upgrading the lockfile in #1543

Fixes the error:

```
src/index.ts → dist/vue-test-utils.esm-bundler.mjs...
[!] (plugin commonjs--resolver) Error: /home/runner/work/test-utils/test-utils/src/stubs.ts(77,14): semantic error TS2742: The inferred type of 'createStub' cannot be named without a reference to '@vue/compiler-dom/node_modules/@vue/shared'. This is likely not portable. A type annotation is necessary.
```

that we see when upgrading the lockfile in vuejs#1543
@netlify
Copy link

netlify bot commented May 27, 2022

Deploy Preview for vue-test-utils-docs failed.

Name Link
🔨 Latest commit 22ea775
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/62907838a5658e0009a2eb4e

@cexbrayat
Copy link
Member Author

I'm merging this one, even if Netlify is failing, as it allows to update the lockfile in #1543 and hopefully fix Netlify build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant