test: migrate to vitest #1637
Merged
test: migrate to vitest #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
lmiller1990
reviewed
Jul 2, 2022
|
Cool - happy to merge this if we can get everything green. Definitely not my biggest priority, but nice to see Vitest is getting more mature. |
okxiaoliang4
commented
Jul 2, 2022
| // TODO: Find out why this does not work | ||
| // Is it valid to have an AsyncComponent as the root? Was it ever? | ||
| it.skip('works when AsyncComponent is the root', async () => { | ||
| it('works when AsyncComponent is the root', async () => { |
There was a problem hiding this comment.
fix the test fail
|
@okxiaoliang4 Would you mind rebasing the PR and fixing the conflicts please? I'll merge when it's done |
|
🎉 I actually have no problem with Jest... but happy to adopt Vitest, much of a muchness, really. |
|
@cexbrayat done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate to
vitestvitesttest for sourceTest Files 52 passed (52) Tests 403 passed | 1 todo (404) Time 16.35s (in thread 4.93s, 331.63%)vitesttest for productTest Files 52 passed (52) Tests 403 passed | 1 todo (404) Time 14.89s (in thread 4.58s, 325.36%)jesttest for sourcejesttest for product