Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup event listeners on unmount #1793

Merged
merged 1 commit into from Oct 4, 2022

Conversation

freakzlike
Copy link
Collaborator

fix #1787

This is only a first implementation. There might be some more to optimize

@netlify
Copy link

netlify bot commented Oct 4, 2022

Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit c4936b3
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/633c49d674982b0009bd5c96
😎 Deploy Preview https://deploy-preview-1793--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for taking a look at this issue

@cexbrayat cexbrayat merged commit 149e11f into vuejs:main Oct 4, 2022
@freakzlike freakzlike deleted the fix/memory-leak branch February 20, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Possible memory leak when using real Vuex store in plugins
2 participants