Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added typescript documentation to plugins.md #1796

Merged
merged 1 commit into from Oct 6, 2022
Merged

added typescript documentation to plugins.md #1796

merged 1 commit into from Oct 6, 2022

Conversation

mrcwbr
Copy link
Contributor

@mrcwbr mrcwbr commented Oct 5, 2022

as you mentioned in #1792 I created a custom plugin. if you want to use plugins in a typescript project you have to redefine the declaration of the VueWrapper. Therefore, I updated the docs

@netlify
Copy link

netlify bot commented Oct 5, 2022

Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit 309a2f3
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/633ef9a19e1c1b000abb8913
😎 Deploy Preview https://deploy-preview-1796--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Can you rebase and resolve the conflicts so we can merge it?

@@ -41,7 +41,7 @@ export default abstract class BaseWrapper<ElementType extends Node>
return this.wrapperElement
}

constructor(element: ElementType) {
protected constructor(element: ElementType) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this does anything - this class is already abstract so you cannot make an instance of it anyway. Might be good to revert an unnecessary change, unless I'm missing something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

it was a hint from intelliJ

@mrcwbr
Copy link
Contributor Author

mrcwbr commented Oct 6, 2022

LGTM thanks!

Can you rebase and resolve the conflicts so we can merge it?

done

@cexbrayat cexbrayat merged commit 5c59fa2 into vuejs:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants