fix(stubs): teleport stub children as a function #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
freakzlike
reviewed
Oct 26, 2022
cexbrayat
force-pushed
the
fix/1829-teleport-children-as-a-function
branch
from
4bb8fd8
to
250610c
Compare
|
@freakzlike I added a test to check that the warning is not logged anymore, and added a check in other tests when it is logged, but when that we expect it. Maybe we should do the same for the warnings logged by vue compact (either mock them or fix them if needed) to avoid polluting the test logs, and missing a regression like this one in the future Anyway, this should fix the issue, unless someone comes up with a better idea. I'll let you give a last check and merge |
cexbrayat
force-pushed
the
fix/1829-teleport-children-as-a-function
branch
from
250610c
to
60268e6
Compare
|
This does feel like a bit of a hack, but okay for now. I am not sure of a better way. Warnings are not much fun. let's merge this up with one more ✅ and release. |
lmiller1990
approved these changes
Oct 27, 2022
freakzlike
approved these changes
Oct 27, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1829
I'm not super convinced by this fix, but it indeed looks like @freakzlike intuition is right: we need to return the children as a function for Teleport to avoid the warning.
Maybe @xanf you have a better idea on how to handle that?