fix: allow mocking on script setup components #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cexbrayat
force-pushed
the
repro/set-trap-error
branch
from
5b24de6
to
fb36908
Compare
|
This one is trickier. Until now, we used a mixin with a beforeCreate to populate the mocks (the code is probably inherited from VTU v1). But the recent changes in Vue makes such a modification to a script setup component impossible if they come from a component written with the Options API. See vuejs/core@f73925d#diff-ea4d1ddabb7e22e17e80ada458eef70679af4005df2a1a6b73418fec897603ceR404 I have not found a way to make it work in all cases. If someone thinks about a potential fix, feel free to take a stab. |
We need to differentiate how the mixin used for mocking updates the isntance, as Vue v3.2.45 now forbids to update directly a script setup component from a component written with the Options API. Fixes the error `set' on proxy: trap returned falsish for property` This comes from the fact that mocks are set via a mixin (Options API) and we run into the more strict behavior of Vue v3.2.45 introduced in vuejs/core@f73925d#diff-ea4d1ddabb7e22e17e80ada458eef70679af4005df2a1a6b73418fec897603ceR404
cexbrayat
force-pushed
the
repro/set-trap-error
branch
from
fb36908
to
d9d604c
Compare
cexbrayat
changed the title
|
I now have a potential fix, by still using a mixin, but updating |
lmiller1990
approved these changes
Nov 15, 2022
This was referenced Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes from the fact that mocks are set via a mixin (Options API) and we run into the more strict behavior of Vue v3.2.45 introduced in vuejs/core@f73925d#diff-ea4d1ddabb7e22e17e80ada458eef70679af4005df2a1a6b73418fec897603ceR404
First spotted by @Akryum and reported on internal discord
The test succeeds with Vue v3.2.44 and not with Vue v3.2.45