Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add section about test runners upgrade to migration guide #1923

Conversation

renatodeleao
Copy link
Contributor

@renatodeleao renatodeleao commented Dec 23, 2022

Why

Context: vuejs/vue-test-utils#1975 (comment)

As discussed, there are a couple of issues that the community faced while upgrading to vue@3 + @vue/test-utils@^2 but that are not directly related to them.

In an effort to make migrations smoother, a new section was added to the migration guide that lists some common problems with underlying test runners. These can be common, due to the fact that users took the opportunity to upgrade their test stack dependencies as well since they were already doing the testing library migration.

What

It adds a few issues with jest, it starts with an issue reported in the legacy test-utils repo and another one that I've personally faced.

Hopefully, the community can see this as a headstart and add more to the jest chapter and also include advice for other test runners.

Context: vuejs/vue-test-utils#1975 (comment)
As discussed, there a couple of issues that the community faced while upgrading
to vue@3 @vue/test-utils@^2 but that are not directly related with them.

In a effort to make migrations more smooth, a new section  was added
to the migration docs that lists some common problems with underlying
test runners, that might happen simply because of the fact that
users took the opportunity to upgrade their test stacks dependecies
as well.

It starts with a few issues with jest, one reported in the
legacy test-utils repo and other one that i've personally faced.

vuejs/vue-test-utils#1975
@netlify
Copy link

netlify bot commented Dec 23, 2022

Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit 536b84a
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/63a5edab4ebd0200081b9447
😎 Deploy Preview https://deploy-preview-1923--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @renatodeleao 👍

docs/migration/index.md Outdated Show resolved Hide resolved
docs/migration/index.md Outdated Show resolved Hide resolved
Co-Authored-By: Cédric Exbrayat <cexbrayat@users.noreply.github.com>
@renatodeleao
Copy link
Contributor Author

@cexbrayat thanks for proof reading it! Feel free to edit or tweak the writing/formatting to make it match the rest of the guide if you will!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants