fix(theme): hide doc footer if empty (#1126)

vuejs · Aug 5, 2022 · 70da5f2 · 70da5f2
1 parent 8e190aa
commit 70da5f2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/src/client/theme-default/components/VPDocFooter.vue b/src/client/theme-default/components/VPDocFooter.vue
@@ -13,15 +13,21 @@ const { theme, page, frontmatter } = useData()
 const editLink = useEditLink()
 const control = usePrevNext()
 
+const hasEditLink = computed(() => {
+  return theme.value.editLink && frontmatter.value.editLink !== false
+})
 const hasLastUpdated = computed(() => {
   return page.value.lastUpdated && frontmatter.value.lastUpdated !== false
 })
+const showFooter = computed(() => {
+  return hasEditLink.value || hasLastUpdated.value || control.value.prev || control.value.next
+})
 </script>
 
 <template>
-  <footer class="VPDocFooter">
-    <div class="edit-info">
-      <div v-if="theme.editLink && frontmatter.editLink !== false" class="edit-link">
+  <footer v-if="showFooter" class="VPDocFooter">
+    <div v-if="hasEditLink || hasLastUpdated" class="edit-info">
+      <div v-if="hasEditLink" class="edit-link">
         <VPLink class="edit-link-button" :href="editLink.url" :no-icon="true">
           <VPIconEdit class="edit-link-icon" />
           {{ editLink.text }}

diff --git a/src/client/theme-default/support/sidebar.ts b/src/client/theme-default/support/sidebar.ts
@@ -27,14 +27,14 @@ export function getSidebar(
   return []
 }
 
-export function getFlatSideBarLinks(
-  sidebar: DefaultTheme.SidebarGroup[]
-): DefaultTheme.SidebarItem[] {
-  const links: DefaultTheme.SidebarItem[] = []
+export function getFlatSideBarLinks(sidebar: DefaultTheme.SidebarGroup[]) {
+  const links: { text: string; link: string }[] = []
 
   function recursivelyExtractLinks(items: DefaultTheme.SidebarItem[]) {
     for (const item of items) {
-      item.link && links.push(item)
+      if (item.link) {
+        links.push({ ...item, link: item.link })
+      }
       if ('items' in item) {
         recursivelyExtractLinks(item.items)
       }