Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localhost dead links #1019

Closed
3 tasks done
johanjvrens opened this issue Jul 19, 2022 · 1 comment
Closed
3 tasks done

localhost dead links #1019

johanjvrens opened this issue Jul 19, 2022 · 1 comment
Labels
bug: pending triage Maybe a bug, waiting for confirmation

Comments

@johanjvrens
Copy link

Describe the bug

When running Vitepress I get the following dead link error messages for my localhost server:
-(!) Found dead link http://localhost:4000/#/...

When I click on the links they open up without any issues.
When I set the config to ignore the dead links:

import { defineConfig } from "vitepress";

export default defineConfig({
  ignoreDeadLinks: true
});

and try to build I still get the following error:

⠼ building client + server bundles...[vitepress] One or more pages contain dead links.
✖ building client + server bundles...
build error:
 Error: One or more pages contain dead links.

Reproduction

Point a link to a local server running on localhost. In my case, I'm pointing it to cubejs dev server running on localhost port 4000 http://localhost:4000/#/build?query={}

code in Vitepress:

[link to localhost endpoint](http://localhost:4000/#/build?query={})

Expected behavior

The link should not be reported as a dead link as it is working, maybe display a warning as this is a link pointing to localhost to make sure this is the desired host in my case it is.

If I set the config to ignore deadlink, it should build and not fail

import { defineConfig } from "vitepress";

export default defineConfig({
  ignoreDeadLinks: true
});

System Info

System:
    OS: macOS 12.4
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 25.68 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.16.0 - /usr/local/opt/node@16/bin/node
    npm: 8.11.0 - /usr/local/opt/node@16/bin/npm
  Browsers:
    Chrome: 103.0.5060.114
    Safari: 15.5
  npmPackages:
    vitepress: 1.0.0-alpha.4 => 1.0.0-alpha.4

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@johanjvrens johanjvrens added the bug: pending triage Maybe a bug, waiting for confirmation label Jul 19, 2022
@brc-dd
Copy link
Member

brc-dd commented Jul 19, 2022

#941 (comment)

@brc-dd brc-dd closed this as completed Jul 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug: pending triage Maybe a bug, waiting for confirmation
Projects
None yet
Development

No branches or pull requests

2 participants