Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): fix custom Not found page rendering #1163

Merged
merged 2 commits into from Aug 14, 2022
Merged

fix(theme): fix custom Not found page rendering #1163

merged 2 commits into from Aug 14, 2022

Conversation

Roman3349
Copy link
Contributor

Signed-off-by: Roman Ondráček ondracek.roman@centrum.cz

Signed-off-by: Roman Ondráček <ondracek.roman@centrum.cz>
@brc-dd
Copy link
Member

brc-dd commented Aug 14, 2022

What was the issue?

@Roman3349
Copy link
Contributor Author

@brc-dd If you are using the default theme with custom Not found page, without this fix the page is rendered in doc layout.

Without fix
without-fix

With fix
with-fix

@brc-dd brc-dd merged commit 4a6eda4 into vuejs:main Aug 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants