Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bundle type definitions of dev-deps #1257

Merged
merged 10 commits into from Aug 30, 2022
Merged

feat: bundle type definitions of dev-deps #1257

merged 10 commits into from Aug 30, 2022

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Aug 30, 2022

fixes #1254

@brc-dd brc-dd marked this pull request as draft August 30, 2022 07:45
@brc-dd brc-dd marked this pull request as ready for review August 30, 2022 10:46
@brc-dd brc-dd marked this pull request as draft August 30, 2022 11:07
@brc-dd brc-dd marked this pull request as ready for review August 30, 2022 11:16
@brc-dd brc-dd marked this pull request as draft August 30, 2022 11:24
@brc-dd brc-dd marked this pull request as ready for review August 30, 2022 11:45
@brc-dd brc-dd marked this pull request as draft August 30, 2022 12:42
@brc-dd brc-dd marked this pull request as ready for review August 30, 2022 13:26
@brc-dd brc-dd marked this pull request as draft August 30, 2022 13:40
@brc-dd brc-dd marked this pull request as ready for review August 30, 2022 13:45
@brc-dd brc-dd requested a review from meteorlxy August 30, 2022 13:48
@brc-dd
Copy link
Member Author

brc-dd commented Aug 30, 2022

There are some more changes.

  • We need to manually define Header because shared.d.ts is not processed by rollup (hence, types from @mdit-vue/plugin-header won't be bundled).

  • shared.d.ts was getting bundled (and duplicated) in client and node types, so externalized that.

  • Explicit re-exporting is now not required in types/index.d.ts because exports now don't have any conflicts.

  • Stuff like this can now again be done without any issues:

    declare module 'vitepress' {
      interface Header {
        compositionOnly?: boolean
        optionsOnly?: boolean
      }
    }

Copy link
Member

@meteorlxy meteorlxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brc-dd brc-dd merged commit 12591a9 into main Aug 30, 2022
@brc-dd brc-dd deleted the feat/bundle-types branch August 30, 2022 17:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundle types of dev-deps properly
2 participants